Skip to content

fix(config): properly track if an ignore entry has been used#2456

Merged
G-Rath merged 1 commit into
google:mainfrom
ackama:fix/config-checking
Jan 11, 2026
Merged

fix(config): properly track if an ignore entry has been used#2456
G-Rath merged 1 commit into
google:mainfrom
ackama:fix/config-checking

Conversation

@G-Rath
Copy link
Copy Markdown
Collaborator

@G-Rath G-Rath commented Jan 9, 2026

Resolves #2455

@G-Rath G-Rath added the bug Something isn't working label Jan 9, 2026
@G-Rath G-Rath force-pushed the fix/config-checking branch 2 times, most recently from 4ab3848 to 8a7bd74 Compare January 11, 2026 20:02
@another-rex
Copy link
Copy Markdown
Collaborator

Missing some &'s in want entries

@G-Rath G-Rath force-pushed the fix/config-checking branch from 8a7bd74 to 5a0e8b5 Compare January 11, 2026 23:30
@G-Rath G-Rath enabled auto-merge (squash) January 11, 2026 23:31
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.77%. Comparing base (1d5c0ba) to head (5a0e8b5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2456      +/-   ##
==========================================
- Coverage   67.81%   67.77%   -0.05%     
==========================================
  Files         172      172              
  Lines       13318    13318              
==========================================
- Hits         9032     9026       -6     
- Misses       3573     3576       +3     
- Partials      713      716       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@G-Rath G-Rath merged commit 901e233 into google:main Jan 11, 2026
17 checks passed
@G-Rath G-Rath deleted the fix/config-checking branch January 11, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect warning for "unused ignores"

3 participants